From f948899cb01e9809bcf4986ca3faabc9fbaf2edc Mon Sep 17 00:00:00 2001 From: Aelin Date: Wed, 3 Jun 2026 00:43:05 +0200 Subject: [PATCH] docs: Add approval rules flowchart Apparently our rules are complicated enough that this is necessary. I am *not* an expert at Inkscape, so bear with me. This is also my interpretation of the rules, if I got anything wrong, please correct me. Part-of: --- docs/approval-rules.md | 4 + docs/approval-rules.svg | 834 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 838 insertions(+) create mode 100644 docs/approval-rules.svg diff --git a/docs/approval-rules.md b/docs/approval-rules.md index f60f477cf..298e5958f 100644 --- a/docs/approval-rules.md +++ b/docs/approval-rules.md @@ -26,6 +26,10 @@ with any 2 approvals from team members. The submitting maintainer may choose to block the merge request to wait for co-maintainer review beyond the 48-hour window if desired. +The following flowchart describes the process: + +![Approval rules](./approval-rules.svg) + ## Move device from category Moving devices from category is a special operation, see diff --git a/docs/approval-rules.svg b/docs/approval-rules.svg new file mode 100644 index 000000000..62f2a6ec7 --- /dev/null +++ b/docs/approval-rules.svg @@ -0,0 +1,834 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Is the MR critical or trivial? + + 1 any approval + + Is the author the sole +maintainer of the package? + + + Yes + No + + Yes + + Does the package have a +maintainer? + + No + + 2 any approvals + + No + + Is the author a maintainer +of the package? + + Yes + + Wait up +to two weeks for a +maintainer review + + Open a new +issue about it using the +template + + No + + Did a maintainer +reply? + + + No + + + Wait up to 48 +hours for co-maintainers +to review + + Yes + + Did a co-maintainer +reply? + + + No + + 1 any approval, +1 maintainer +approval + + Yes + + Yes + + if review comments were made +and addressed + START + +