From d44b34bebd38fdcd01d9b2d6bce1ac2d16734f93 Mon Sep 17 00:00:00 2001 From: Bart Ribbers Date: Fri, 10 Jan 2020 17:39:12 +0100 Subject: [PATCH] firmware/firmware-hisense-m470bsa: fix linting issues (!873) I'm not sure how this package even worked before... The install location on the second loop was invalid as the "$fw" variable would result to nothing. This would normally cause all files in that loop to be named the same... --- firmware/firmware-hisense-m470bsa/APKBUILD | 27 +++++++++++----------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/firmware/firmware-hisense-m470bsa/APKBUILD b/firmware/firmware-hisense-m470bsa/APKBUILD index fc73c23d7..2ec264dd1 100644 --- a/firmware/firmware-hisense-m470bsa/APKBUILD +++ b/firmware/firmware-hisense-m470bsa/APKBUILD @@ -1,29 +1,30 @@ +# Contributor: Hunter Sell pkgname=firmware-hisense-m470bsa pkgver=1 -pkgrel=0 +pkgrel=1 +_commit="42fbba77c06cf822021554ed1b0e4736dbce2e72" pkgdesc="Hisense Sero 7 Pro Firmware" url="https://github.com/dolorespark/android_vendor_hisense_m470bsa" arch="armv7" license="proprietary" - -# Source -_commit="42fbba77c06cf822021554ed1b0e4736dbce2e72" -source="https://github.com/dolorespark/android_vendor_hisense_m470bsa/archive/${_commit}.tar.gz" -options="!check !strip" +source="https://github.com/dolorespark/android_vendor_hisense_m470bsa/archive/$_commit.tar.gz" +options="!check !strip !archcheck !spdx" +builddir="$srcdir/android_vendor_hisense_m470bsa-$_commit" package() { - cd "$srcdir/android_vendor_hisense_m470bsa-${_commit}" # Wifi for _i in fw_bcmdhd.bin fw_bcmdhd_apsta.bin; do - install -Dm644 "prebuilt/vendor/firmware/bcm4330/$_i" \ - "$pkgdir/lib/firmware/postmarketos/bcm4330/$_i" + install -Dm644 prebuilt/vendor/firmware/bcm4330/"$_i" \ + "$pkgdir"/lib/firmware/postmarketos/bcm4330/"$_i" done + for _fw in BCM20791B4_002.005.010.0103.0000_Hisense_I2CGED_NCD_Signed_Test.ncd BCM20791B4_002.005.010.0103.0000_Hisense_PreI2C_NCD_Signed_Test.ncd tlv320aic3206_fw_v1.bin; do - install -Dm644 "prebuilt/vendor/firmware/$_fw" \ - "$pkgdir/lib/firmware/postmarketos/$fw" + install -Dm644 prebuilt/vendor/firmware/"$_fw" \ + "$pkgdir"/lib/firmware/postmarketos/"$_fw" done - install -Dm644 "prebuilt/etc/nvram_4330.txt" \ - "$pkgdir/lib/firmware/postmarketos/nvram_4330.txt" + + install -Dm644 prebuilt/etc/nvram_4330.txt \ + "$pkgdir"/lib/firmware/postmarketos/nvram_4330.txt } sha512sums="131f9bd8f50eae8df25f5857c775163a6d61e1e2a708b2a921c18a36d7b75d1075af82d927affe759e476932920e201da06100a9b975d116583c4401d84a8662 42fbba77c06cf822021554ed1b0e4736dbce2e72.tar.gz"