Piecuu/pmaports
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ci: grep: disallow nonfree-firmware subpackages

Browse source 
The original disallowing of these subpackages happened in 2024.
It was expected that device packages would be voluntarily migrated
by the maintainers to reflect this new rule. But, this never happened.
Thus, enforcing this on all new and changed packages will force
the fixing of these packages.

This is not a treewide because so many packages still use the
nonfree-firmware subpackage logic that an MR would be an absolute pain
to handle and rebase. This is also a very easy fix to incorporate into
unrelated changes.

See https://postmarketos.org/edge/2024/02/15/default-nonfree-fw/

Part-of: <https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/8914>
This commit is contained in:
Aster Boese 2026-06-26 20:02:11 +02:00 • committed by The Friendly Meow (merge) Bot
parent 34a631a01e
commit 51d322dd4b
No known key found for this signature in database
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
.ci/grep.sh
View file

@ -180,6 +180,18 @@ if [ -n "$CI_MERGE_REQUEST_DIFF_BASE_SHA" ]; then
fi
fi
# Disallow non-free firmware subpackages
CHANGED_APKBUILDS=$(git show --pretty="" --name-only --diff-filter=AMR "$CI_MERGE_REQUEST_DIFF_BASE_SHA"..HEAD | grep APKBUILD || true)
if [ -n "$CHANGED_APKBUILDS" ]; then
if [ -n "$(grep -r 'pkgname-nonfree-firmware' $CHANGED_APKBUILDS || true)" ]; then
echo "ERROR: Please remove the nonfree-firmware subpackage(s) and move the firmware to depends in the following APKBUILDs."
echo "See https://docs.postmarketos.org/pmaports/main/packaging/firmware-packages.html"
grep --color=always -l 'pkgname-nonfree-firmware' $CHANGED_APKBUILDS
exit_code=1
fi
fi
# Get latest commit message in MR
case "$CI_COMMIT_DESCRIPTION" in
*"[ci:skip-grep]"*)