Moshe Shemesh da2e552b46 net/mlx5: Fix command stats access after free ... Command may fail while driver is reloading and can't accept FW commands till command interface is reinitialized. Such command failure is being logged to command stats. This results in NULL pointer access as command stats structure is being freed and reallocated during mlx5 devlink reload (see kernel log below). Fix it by making command stats statically allocated on driver probe. Kernel log: [ 2394.808802] BUG: unable to handle kernel paging request at 000000000002a9c0 [ 2394.810610] PGD 0 P4D 0 [ 2394.811811] Oops: 0002 [#1] SMP NOPTI ... [ 2394.815482] RIP: 0010:native_queued_spin_lock_slowpath+0x183/0x1d0 ... [ 2394.829505] Call Trace: [ 2394.830667] _raw_spin_lock_irq+0x23/0x26 [ 2394.831858] cmd_status_err+0x55/0x110 [mlx5_core] [ 2394.833020] mlx5_access_reg+0xe7/0x150 [mlx5_core] [ 2394.834175] mlx5_query_port_ptys+0x78/0xa0 [mlx5_core] [ 2394.835337] mlx5e_ethtool_get_link_ksettings+0x74/0x590 [mlx5_core] [ 2394.836454] ? kmem_cache_alloc_trace+0x140/0x1c0 [ 2394.837562] __rh_call_get_link_ksettings+0x33/0x100 [ 2394.838663] ? __rtnl_unlock+0x25/0x50 [ 2394.839755] __ethtool_get_link_ksettings+0x72/0x150 [ 2394.840862] duplex_show+0x6e/0xc0 [ 2394.841963] dev_attr_show+0x1c/0x40 [ 2394.843048] sysfs_kf_seq_show+0x9b/0x100 [ 2394.844123] seq_read+0x153/0x410 [ 2394.845187] vfs_read+0x91/0x140 [ 2394.846226] ksys_read+0x4f/0xb0 [ 2394.847234] do_syscall_64+0x5b/0x1a0 [ 2394.848228] entry_SYSCALL_64_after_hwframe+0x65/0xca Fixes: 34f46ae0d4 ("net/mlx5: Add command failures data to debugfs") Signed-off-by: Moshe Shemesh <moshe@nvidia.com> Reviewed-by: Shay Drory <shayd@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>		2023-01-09 22:08:34 -08:00
..
cq.h	net/mlx5: Use mlx5_cmd_do() in core create_{cq,dct}	2022-02-23 15:21:59 -08:00
device.h	net/mlx5: E-Switch, properly handle ingress tagged packets on VST	2022-12-28 11:38:49 -08:00
doorbell.h	net/mlx5: Remove spinlock support from mlx5_write64	2019-04-02 12:49:37 -07:00
driver.h	net/mlx5: Fix command stats access after free	2023-01-09 22:08:34 -08:00
eq.h	net/mlx5: Introduce API for bulk request and release of IRQs	2022-01-06 16:22:52 -08:00
eswitch.h	net/mlx5: E-switch, Remove dependency between sriov and eswitch mode	2022-07-02 11:58:26 -07:00
fs.h	net/mlx5: fs, add match on ranges API	2022-12-08 16:10:53 -08:00
fs_helpers.h	net/mlx5: Remove unused functions	2022-09-27 12:50:27 -07:00
mlx5_ifc.h	net/mlx5: E-Switch, properly handle ingress tagged packets on VST	2022-12-28 11:38:49 -08:00
mlx5_ifc_fpga.h	net/mlx5: Remove from FPGA IFC file not-needed definitions	2022-09-27 12:50:27 -07:00
mlx5_ifc_vdpa.h	vdpa/mlx5: Implement susupend virtqueue callback	2022-08-11 04:26:08 -04:00
mpfs.h	{net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table	2021-05-18 23:01:48 -07:00
port.h	IB/mlx5: Fix undefined behavior due to shift overflowing the constant	2022-04-06 10:15:03 +03:00
qp.h	net/mlx5e: xsk: Use KSM for unaligned XSK	2022-09-30 07:55:46 -07:00
rsc_dump.h	net/mlx5: Add support in query QP, CQ and MKEY segments	2020-06-23 17:26:10 +03:00
transobj.h	net/mlx5e: Fix page reclaim for dead peer hairpin	2021-06-09 17:20:03 -07:00
vport.h	net/mlx5: Add generic getters for other functions caps	2022-12-07 20:09:18 -08:00