Larry Finger 9f2a0fac62 b43: Fix warning at drivers/mmc/core/core.c:237 in mmc_wait_for_cmd ... On module removal, the sdio version of b43 generates the following warning: [ 851.560519] ------------[ cut here ]------------ [ 851.560531] WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd+0x88/0x90() [ 851.560534] Hardware name: 20552PG [ 851.560536] Modules linked in: b43(-) ssb mmc_block binfmt_misc rfcomm sco bnep ppdev l2cap ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables bridge stp kvm_intel kvm arc4 iwlagn snd_hda_codec_conexant snd_hda_intel snd_hda_codec iwlcore snd_hwdep snd_pcm thinkpad_acpi mac80211 snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq r852 joydev snd_timer sm_common pcmcia nand snd_seq_device cfg80211 sdhci_pci btusb psmouse tpm_tis yenta_socket nand_ids lp snd pcmcia_rsrc nand_ecc bluetooth sdhci tpm pcmcia_core parport mtd snd_page_alloc serio_raw tpm_bios soundcore nvram led_class sha256_generic aes_i586 aes_generic dm_crypt i915 drm_kms_helper drm ahci intel_agp i2c_algo_bit intel_gtt e1000e libahci video agpgart output [ 851.560620] Pid: 2504, comm: rmmod Not tainted 2.6.36-titan0+ #1 [ 851.560622] Call Trace: [ 851.560631] [<c014a102>] warn_slowpath_common+0x72/0xa0 [ 851.560636] [<c04d94c8>] ? mmc_wait_for_cmd+0x88/0x90 [ 851.560641] [<c04d94c8>] ? mmc_wait_for_cmd+0x88/0x90 [ 851.560645] [<c014a152>] warn_slowpath_null+0x22/0x30 [ 851.560649] [<c04d94c8>] mmc_wait_for_cmd+0x88/0x90 [ 851.560655] [<c0401585>] ? device_release+0x25/0x80 [ 851.560660] [<c04df210>] mmc_io_rw_direct_host+0xa0/0x150 [ 851.560665] [<c04df370>] mmc_io_rw_direct+0x30/0x40 [ 851.560669] [<c04e06e7>] sdio_disable_func+0x37/0xa0 [ 851.560683] [<f8dfcb80>] b43_sdio_remove+0x30/0x50 [b43] [ 851.560687] [<c04df8cc>] sdio_bus_remove+0x1c/0x60 [ 851.560692] [<c016d39f>] ? blocking_notifier_call_chain+0x1f/0x30 [ 851.560697] [<c0404991>] __device_release_driver+0x51/0xb0 [ 851.560701] [<c0404a7f>] driver_detach+0x8f/0xa0 [ 851.560705] [<c0403c83>] bus_remove_driver+0x63/0xa0 [ 851.560709] [<c0405039>] driver_unregister+0x49/0x80 [ 851.560713] [<c0405039>] ? driver_unregister+0x49/0x80 [ 851.560718] [<c04dfad7>] sdio_unregister_driver+0x17/0x20 [ 851.560727] [<f8dfcb42>] b43_sdio_exit+0x12/0x20 [b43] [ 851.560734] [<f8dfe76f>] b43_exit+0x17/0x3c [b43] [ 851.560740] [<c017fb8d>] sys_delete_module+0x13d/0x200 [ 851.560747] [<c01fd7d2>] ? do_munmap+0x212/0x300 [ 851.560752] [<c010311f>] sysenter_do_call+0x12/0x28 [ 851.560757] ---[ end trace 31e14488072d2f7d ]--- [ 851.560759] ------------[ cut here ]------------ The warning is caused by b43 not claiming the device before calling sdio_disable_func(). Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Reported-by: Arnd Hannemann <arnd@arndnet.de> Tested-by: Arnd Hannemann <arnd@arndnet.de> Cc: Stable <stable@kernel.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>		2010-10-29 14:35:06 -04:00
..
b43.h	b43: define B43_SHM_SH_CHAN_40MHZ	2010-10-06 16:30:41 -04:00
debugfs.c	net/wireless: use generic_file_llseek in debugfs	2010-09-16 10:33:08 +02:00
debugfs.h
dma.c	b43: replace the ssb_dma API with the generic DMA API	2010-06-04 16:00:42 -04:00
dma.h	drivers/net: use __packed annotation	2010-06-03 03:18:23 -07:00
Kconfig	b43: fall back gracefully to PIO mode after fatal DMA errors	2010-02-26 17:26:16 -05:00
leds.c	b43: fix two warnings	2009-12-04 14:16:25 -05:00
leds.h
lo.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
lo.h
main.c	mac80211: use cipher suite selectors	2010-08-16 16:45:11 -04:00
main.h
Makefile	b43: N-PHY: put 2056-radio's specific code in separated file	2010-10-15 15:57:40 -04:00
pcmcia.c	pcmcia: move driver name to struct pcmcia_driver	2010-09-29 17:20:24 +02:00
pcmcia.h
phy_a.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
phy_a.h
phy_common.c	b43: define B43_SHM_SH_CHAN_40MHZ	2010-10-06 16:30:41 -04:00
phy_common.h	b43: N-PHY: replace N-specific radio_chanspec with common code	2010-10-15 15:57:36 -04:00
phy_g.c	b43: silence most sparse warnings	2010-07-21 14:37:38 -04:00
phy_g.h
phy_lp.c	b43: silence most sparse warnings	2010-07-21 14:37:38 -04:00
phy_lp.h
phy_n.c	b43: N-PHY: fix infinite-loop-typo	2010-10-25 14:45:55 -04:00
phy_n.h	b43: N-PHY: put radio-specific code in separated file	2010-10-15 15:57:38 -04:00
pio.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
pio.h	b43: remove get_tx_stats() mac80211 op	2010-02-08 16:51:00 -05:00
radio_2055.c	b43: N-PHY: put radio-specific code in separated file	2010-10-15 15:57:38 -04:00
radio_2055.h	b43: N-PHY: put radio-specific code in separated file	2010-10-15 15:57:38 -04:00
radio_2056.c	b43: N-PHY: put 2056-radio's specific code in separated file	2010-10-15 15:57:40 -04:00
radio_2056.h	b43: N-PHY: put 2056-radio's specific code in separated file	2010-10-15 15:57:40 -04:00
rfkill.c	b43: avoid PPC fault during resume	2009-12-04 13:28:49 -05:00
rfkill.h
sdio.c	b43: Fix warning at drivers/mmc/core/core.c:237 in mmc_wait_for_cmd	2010-10-29 14:35:06 -04:00
sdio.h
sysfs.c
sysfs.h
tables.c
tables.h
tables_lpphy.c
tables_lpphy.h
tables_nphy.c	b43: N-PHY: put 2056-radio's specific code in separated file	2010-10-15 15:57:40 -04:00
tables_nphy.h	b43: N-PHY: put 2056-radio's specific code in separated file	2010-10-15 15:57:40 -04:00
wa.c	b43: silence most sparse warnings	2010-07-21 14:37:38 -04:00
wa.h
xmit.c	b43: remove usage of deprecated noise value	2010-04-28 16:48:21 -04:00
xmit.h	drivers/net: use __packed annotation	2010-06-03 03:18:23 -07:00