Piecuu/linux-samsung-r9q2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ALSA: ppc: drop if block with always false condition

Browse source 
The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20201126165950.2554997-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Uwe Kleine-König 2020-11-26 17:59:49 +01:00 • committed by Takashi Iwai
parent 83ab7b45a2
commit 5c7797022f
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
sound/ppc/snd_ps3.c
View file

@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev)
{
int ret;
pr_info("%s:start id=%d\n", __func__, dev->match_id);
if (dev->match_id != PS3_MATCH_ID_SOUND)
return -ENXIO;
/*
* ctl and preallocate buffer will be freed in